Open
Conversation
Contributor
Author
|
Make changes: Tab 1: Direct Table Path Tab 2: Managed Table (Catalog) |
Results look correct: 51,793 rows — matches TPC-H lineitem SF0.01 with the l_extendedprice < 10000 rows deleted (per the README, full SF0.01 has ~60K rows) 16 columns — standard TPC-H lineitem schema (l_orderkey, l_partkey, ... l_comment) Types are reasonable — INTEGER, DECIMAL(15,2), VARCHAR, DATE Both models (with and without secrets) return the same 51,793 count
royendo
changed the title
royendo
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ericpgreen2
requested review from
AdityaHegde
and removed request for
ericpgreen2
AdityaHegde
requested changes
Mar 10, 2026
web-common/src/features/templates/ConnectionTypeSelector.svelte
Outdated
Show resolved
Hide resolved
web-common/src/features/templates/ConnectionTypeSelector.svelte
Outdated
Show resolved
Hide resolved
Resolve conflicts in JSONSchemaFormRenderer and GroupedFieldsRenderer. Update ConnectionTypeSelector to use v2 runtime client API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NamanMahor
reviewed
Mar 10, 2026
NamanMahor
reviewed
Mar 10, 2026
| - # Example: Iceberg model reading from GCS | ||
| type: model | ||
| connector: duckdb | ||
| create_secrets_from_connectors: gcs |
Contributor
There was a problem hiding this comment.
rill support google json credendtial but duckdb only support hmac so I think iceberg_scan only support hmac too. May be better to mention here.
NamanMahor
reviewed
Mar 10, 2026
NamanMahor
requested changes
Mar 10, 2026
NamanMahor
reviewed
Mar 11, 2026
runtime/drivers/duckdb/duckdb.go
Outdated
| fmt.Sprintf("SET secret_directory=%s", safeSQLString(secretDir)), | ||
| ) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
is there any change in this?
Contributor
Author
There was a problem hiding this comment.
ah there was an issue when using iceberg but since its auto installed, reverted!
AdityaHegde
approved these changes
Mar 11, 2026
| {}, | ||
| { query: { enabled: hasRequiredDrivers } }, | ||
| ); | ||
| $: disabledOptions = (() => { |
Collaborator
There was a problem hiding this comment.
nit: when data directly depends on a query response we use selector functions.
Something like,
function getDisabledOptions(client, requiredDrivers) {
const hasRequiredDrivers = Object.keys(requiredDrivers).length > 0;
return createRuntimeServiceAnalyzeConnectors(
client,
{},
{
query: {
select: (data) => {
const existingDrivers = data.connectors.map...
const disabled: Record<string, string> = {};
...
return disabled;
},
enabled: hasRequiredDrivers,
},
},
);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Apache Iceberg as a new connector, leveraging DuckDB's native Iceberg support. Tested with local filesystem and GCS catalogs.
Backend:
Frontend:
Documentation:
Integration tests:
Checklist: